[Azure][container_registry][compute_vm_scaleset] add missing dimensions to the container_registry and compute_vm_scaleset#7314
Merged
tetianakravchenko merged 4 commits intoelastic:mainfrom Aug 11, 2023
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
…link in changelog Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
31 tasks
zmoog
reviewed
Aug 10, 2023
packages/azure_metrics/data_stream/container_registry/agent/stream/stream.yml.hbs
Show resolved
Hide resolved
zmoog
reviewed
Aug 10, 2023
Contributor
zmoog
left a comment
zmoog
left a comment
There was a problem hiding this comment.
The change looks good, maybe we're only missing a couple of dimensions attributes in the Agent configuration template.
packages/azure_metrics/data_stream/container_registry/agent/stream/stream.yml.hbs
Show resolved
Hide resolved
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Contributor
Author
|
@zmoog could you please have another look on this PR? |
|
Package azure_metrics - 1.0.20 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
container_registry:add geolocation as a dimension - https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/microsoft-containerregistry-registries-metrics
use case for this: https://learn.microsoft.com/en-us/azure/container-registry/container-registry-geo-replication
compute_vm_scalesetsome metrics additionally to the
VMnamehaveLUN(Logical Unit Number (LUN) is a number that is used to identify a specific storage device) as a dimensionChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots